Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filter for dict #1099

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Implement filter for dict #1099

merged 1 commit into from
Oct 20, 2024

Conversation

XiangpengHao
Copy link
Contributor

Implement the missing filter function for dict, otherwise it will fallback to arrow filter, which needs to canonicalize, which is slow.

gatesn
gatesn approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@gatesn gatesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🙏

@robert3005 robert3005 merged commit 214e6b1 into spiraldb:develop Oct 20, 2024
4 checks passed
@XiangpengHao XiangpengHao deleted the dict-filter branch October 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatesn gatesn gatesn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiangpengHao @gatesn @robert3005