chore: move infer_schema and infer_data_type into vortex-dtype #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use these in PyVortex without depending on vortex-datafusion.
danking
force-pushed
the
dk/pull-arrow-dtype-conversion-into-arrow-dtype-pacakge
branch
from
2632167
to
edf9b52
Compare
danking
force-pushed
the
dk/pull-arrow-dtype-conversion-into-arrow-dtype-pacakge
branch
from
edf9b52
to
b0ab48f
Compare
AdamGS
previously approved these changes
Oct 17, 2024
lwwmanning
reviewed
Oct 17, 2024
robert3005
requested changes
Oct 17, 2024
There was a problem hiding this comment.
We should not standardise this code but instead come up with a solution. This method is wrong but necessary for datafusion. Not quite sure what the flow is in pyarrow but I would like to avoid this method being api. At most we should copy paste it as an implementation of pyvortex
|
@robert3005 we now bail on lists |
robert3005
reviewed
Oct 18, 2024
| // There are four kinds of lists: List (32-bit offsets), Large List (64-bit), List View | ||
| // (32-bit), Large List View (64-bit). We cannot both guarantee zero-copy and commit to an | ||
| // Arrow dtype because we do not how large our offsets are. | ||
| DType::List(..) => vortex_bail!("Unsupported dtype: {}", dtype), |
There was a problem hiding this comment.
For posterity - we will canonicalize to List View. We should figure out what to do about fixed size lists though
robert3005
approved these changes
Oct 18, 2024
danking
deleted the
dk/pull-arrow-dtype-conversion-into-arrow-dtype-pacakge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use these in PyVortex without depending on vortex-datafusion.