Make serde optional and return VortexError #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gatesn
commented
Mar 15, 2024
•
gatesn
commented
- Make array serde an optional feature
- Make serde return VortexResult not io Result
lwwmanning
reviewed
Mar 15, 2024
| fn serde(&self) -> &dyn ArraySerde { | ||
| self | ||
| fn serde(&self) -> Option<&dyn ArraySerde> { | ||
| Some(self) |
There was a problem hiding this comment.
if this is to check whether an array supports serde... should chunked array check that every chunk serde is Some(_)?
There was a problem hiding this comment.
Not really, the implementation of serde can subsequently fail. This is just a way to maybe get an implementation at runtime
lwwmanning
approved these changes
Mar 15, 2024
|
Why is serde optional? I thought you'd always can convert to another one and serialize that? |
|
Some arrays may be used for lazy compute, e.g. a FilteredArray. Some may model non-vortex serialised arrays, e.g. if we implement a Parquet reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.