Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/monolog-bridge] Set bubble as true by default in logRotate method #997

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Sep 20, 2023

ref: #998

Q A
Bugfix? ✔️
Breaks BC?
New feature?

@msmakouz msmakouz added this to the 3.9 milestone Sep 20, 2023
@msmakouz msmakouz self-assigned this Sep 20, 2023
@msmakouz msmakouz changed the title Set bubble as true by default in logRotate method [spiral/monolog-bridge] Set bubble as true by default in logRotate method Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (fe8484a) 89.43% compared to head (ac5717f) 89.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #997      +/-   ##
============================================
+ Coverage     89.43%   89.45%   +0.02%     
- Complexity     6093     6096       +3     
============================================
  Files           801      802       +1     
  Lines         17204    17239      +35     
============================================
+ Hits          15386    15421      +35     
  Misses         1818     1818              
Files Changed Coverage Δ
...ridge/Monolog/src/Bootloader/MonologBootloader.php 75.00% <ø> (ø)
src/Bridge/Monolog/src/EventHandler.php 100.00% <100.00%> (ø)
src/Bridge/Monolog/tests/EventHandlerTest.php 100.00% <100.00%> (ø)
src/Bridge/Monolog/tests/RotateHandlerTest.php 94.28% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@butschster butschster merged commit 81d9669 into master Sep 20, 2023
9 checks passed
@butschster butschster deleted the bugfix/monolog-bubble branch September 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants