Fix missing markdown include in manifest #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since moving from ReST to Markdown, we forgot to update the manifest to include Markdown files. It means that files such as README.md and CHANGELOG.md are missing from releases. In practice, this broke the description on PyPI: https://pypi.org/project/ihatemoney/6.1.3/
almet
reviewed
Nov 23, 2023
| recursive-include ihatemoney *.rst *.py *.yaml *.po *.mo *.html *.css *.js *.eot *.svg *.woff *.txt *.png *.webp *.ini *.cfg *.j2 *.jpg *.gif *.ico *.xml | ||
| include LICENSE CONTRIBUTORS CHANGELOG.rst | ||
| include *.md | ||
| recursive-include ihatemoney *.py *.yaml *.po *.mo *.html *.css *.js *.eot *.svg *.woff *.txt *.png *.webp *.ini *.cfg *.j2 *.jpg *.gif *.ico *.xml |
There was a problem hiding this comment.
Why not adding *.md it also in the recursive-include ? (wouldn't the doc be excluded by this?)
There was a problem hiding this comment.
We have no markdown file in ihatemoney/, do you think it's useful?
There was a problem hiding this comment.
I was mainly thinking about the documentation. It would be nice to have it included in the release :-)
almet
reviewed
Nov 23, 2023
zorun
added a commit
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Baptiste Jonglez <[email protected]> (cherry picked from commit 2ce1ea4)
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
Co-authored-by: Baptiste Jonglez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving from ReST to Markdown, we forgot to update the manifest to include Markdown files. It means that files such as README.md and CHANGELOG.md are missing from releases. In practice, this broke the description on PyPI:
https://pypi.org/project/ihatemoney/6.1.3/