feat: introduce AudioFeatureTransformer and audio_service #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/spira_training/apps/feature_engineering/feature_engineering.py # src/spira_training/shared/core/audio_processor.py # src/spira_training/shared/core/audio_processor_factory.py # src/spira_training/shared/core/services/feature_engineering_service.py # tests/core/test_audio_processor_factory.py # tests/core/test_feature_engineering_service.py
bolgheroni
reviewed
Oct 23, 2024
There was a problem hiding this comment.
its not a class right? why not?
There was a problem hiding this comment.
i wanted to make it simple and reduce the overhead to manage instance variables and dependencies that making it a class require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft pull request introduce the AudioFeatureTransformer interface, while implementing some concrect class of it.
It also introduce de creation of the audio_service, a class to concentrate important operations to the Audios. I choose create the audio_service because i was doing that operations in the AudioCollection/Audio, GeneratedAudioCollection, but it was creating a cycle dependency.
There are some changes removing the dependency on
PytorchTensorFactoryfrom various files too.