-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ignoring redirects during oauth2 flow #326
Conversation
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
@robert-blackman looks like there are some test failures. |
Hey @dbyron-sf tests are passing locally, is there more here for us to do? |
I'm not sure why, but the PR build checks don't seem to be triggering...maybe try pushing an empty commit to see if that wakes things up? |
@dbyron-sf gave it a kick, looks like the workflow needs to be approved |
Hello, we came across an issue with the OAuth2 login flow.
During a typical login, gate will respond with a 302 redirecting to deck. In the case that the predefined redirect URL is undefined (in our case it is undefined)
localhost:8085
is set as the location. Due to the default behaviour of the go http client, this redirection is followed causing an error when the connection is inevitably refused.This PR adds support for an
ignoreRedirects
configuration and/or--ignore-redirects
command line arg that instructs the client not to follow redirects, the default behaviour should remain the same however. Additionally, the error message has been improved to help diagnose further failures.Thanks!