feat(artifact): Introduces the expansion of artifact store references in parameters #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2024 15:21
This commit updates the Helm util helpers that we have to include the artifact store. This will allow us to inspect the raw strings and check to see if we need to expand them. Further, I opted to not utilize the deserializer this time, since this problem seemed very specific to Helm. If that changes, we can always just use the deserializer Signed-off-by: benjamin-j-powell <[email protected]>
Signed-off-by: benjamin-j-powell <[email protected]>
|
depends on spinnaker/kork#1145 |
dbyron-sf
reviewed
Feb 4, 2024
| String ref = (String) value; | ||
| if (ArtifactReferenceURI.is(ref)) { | ||
| Artifact artifact = artifactStore.get(ArtifactReferenceURI.parse(ref)); | ||
| return artifact.getReference(); |
There was a problem hiding this comment.
Tempting to add a log message here, even at debug, so there's some evidence that this is happening. I suppose this one is sufficient though.
Signed-off-by: benjamin-j-powell <[email protected]>
|
@Mergifyio update |
✅ Branch has been successfully updated |
dbyron-sf
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Helm util helpers that we have to include the
artifact store. This will allow us to inspect the raw strings and check
to see if we need to expand them.
Further, I opted to not utilize the deserializer this time, since this
problem seemed very specific to Helm. If that changes, we can always
just use the deserializer
Signed-off-by: benjamin-j-powell [email protected]