Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetServerGroupResolver cleanup #4523

Merged
merged 4 commits into from
Sep 14, 2023
Merged

TargetServerGroupResolver cleanup #4523

merged 4 commits into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. test(clouddriver): demonstrate behavior when resolveByParams receives… 

    … an invalid response
    @dbyron-sf
    dbyron-sf committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    add52c7 View commit details
    Browse the repository at this point in the history

  2. refactor(clouddriver): use typed endpoints in TargetServerGroupResolver 

    so retrofit handles the conversion from Response to the appropriate type for us.  This
reduces the dependency that TargetServerGroupResolver has on retrofit, and paves the way
to use an OortService client that uses SpinnakerRetrofitErrorHandler.
    @dbyron-sf
    dbyron-sf committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9dc2b3e View commit details
    Browse the repository at this point in the history

  3. refactor(clouddriver): remove OortService.getTargetServerGroup 

    since it's not used
    @dbyron-sf
    dbyron-sf committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e7e3a12 View commit details
    Browse the repository at this point in the history

  4. refactor(clouddriver): rename OortService.oort.getTargetServerGroupTy… 

    …ped to getTargetServerGroup

since it's the only version of that method
    @dbyron-sf
    dbyron-sf committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e2a62c4 View commit details
    Browse the repository at this point in the history