feat(cloudrun): Adding cloudrun provider functionality in orca. #4279
Conversation
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side commit conventions here. |
|
@sanopsmx any chance |
Will write and test and check in. Give me sometime..i will write it in java and check in. |
Modified the code from groovy to java. |
...oovy/com/netflix/spinnaker/orca/kato/pipeline/strategy/DetermineSourceServerGroupTask.groovy
Outdated
Show resolved
Hide resolved
...netflix/spinnaker/orca/clouddriver/tasks/servergroup/WaitForRequiredInstancesDownTask.groovy
Outdated
Show resolved
Hide resolved
| @@ -49,6 +50,7 @@ class DetermineSourceServerGroupTask implements RetryableTask { | |||
|
|
|||
| @Override | |||
| TaskResult execute(StageExecution stage) { | |||
|
|
|||
| @Component | ||
| public class CloudrunServerGroupCreator implements ServerGroupCreator { | ||
|
|
||
| @Autowired ObjectMapper objectMapper; |
There was a problem hiding this comment.
Constructor injection is preferred over property injection
| try { | ||
| yamlMap = yamlReader.readValue(configStr, LinkedHashMap.class); | ||
| if (yamlMap.get("metadata") != null | ||
| && ((LinkedHashMap<String, Object>) yamlMap.get("metadata")).get("labels") != null |
There was a problem hiding this comment.
Is the cast to LinkedHashMap necessary here or can it just be Map?
Added test cases and sent it for review. |
This is part of spinnaker/governance#302
Adding cloudrun provider functionality in orca.