Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add sql to storage options #143

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

nimakaviani
Copy link
Member

Enabling the new datasource providers for redis and sql to be used for Keel

Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nimakaviani! Left a couple of questions.

api/proto/storage/sql.proto Show resolved Hide resolved
api/proto/storage/sql.proto Show resolved Hide resolved
@nimakaviani nimakaviani changed the title feat(storage): add redis and sql to storage options feat(storage): add sql to storage options Sep 30, 2020
@maggieneterval maggieneterval added the ready to merge Reviewed and ready for merge label Sep 30, 2020
@mergify mergify bot merged commit a57d5be into spinnaker:master Sep 30, 2020
@mergify mergify bot added the auto merged label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Reviewed and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants