chore(deps): Bump kork and Kotlin #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispollo
commented
Mar 3, 2021
| @@ -17,8 +17,8 @@ buildscript { | |||
| } | |||
|
|
|||
| plugins { | |||
| kotlin("jvm") version "1.4.21" apply false | |||
| id("org.jetbrains.kotlin.plugin.allopen") version "1.4.21" apply false | |||
| kotlin("jvm") version "1.4.31" apply false | |||
There was a problem hiding this comment.
@robfletcher Is there a way we could avoid specifying the version here and just pick up the version defined in kork?
There was a problem hiding this comment.
It's annoying but it's not possible to specify Gradle plugin versions with a variable / property because they get loaded before anything else (including project properties). It's a long-standing gripe.
lorin
approved these changes
Mar 3, 2021
osoriano
pushed a commit
to osoriano/keel
that referenced
this pull request
Sep 2, 2023
* chore(deps): Bump kork and Kotlin * fix(pr): Fix compile errors with new kotlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps kork to pick up spinnaker/kork#850 and aligns Kotlin version in keel.