Commits on Dec 10, 2021

1. fix(halyard-proto): Removed specified version for com.google.protobuf… …

   …:protobuf-java
   
   Getting below conflict between spring plugin and protobuf plugin while upgrading spring boot 2.2.x(existing kork) to 2.3.x:
   
   "> Task :halyard-proto:generateProto FAILED> Task :halyard-core:compileJava
   Note: /halyard/halyard-core/src/main/java/com/netflix/spinnaker/halyard/core/resource/v1/JarResourceReader.java uses or overrides a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   Note: Some input files use unchecked or unsafe operations.
   Note: Recompile with -Xlint:unchecked for details.FAILURE: Build failed with an exception.* What went wrong:
   Execution failed for task ':halyard-proto:generateProto'.
   > protoc: stdout: . stderr: google/longrunning/operations.proto:33:8: Option ""php_namespace"" unknown.
     deployments.proto: Import ""google/longrunning/operations.proto"" was not found or had errors.
     deployments.proto:13:50: ""google.longrunning.Operation"" is not defined."
   
   Removing specified version of protobuf-java have no impact on current springboot version however will rectify an upcoming issue with springboot 2.3.12.
   It is raised after verifying the effect of upgrading Kork with Springboot version.

   

   madhubkk committed Dec 10, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for c3a0e16
   • Browse repository at this point

   Copy the full SHA

   c3a0e16 View commit details

   Browse the repository at this point in the history