Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Fix logout message #1062

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

kowshikRoy
Copy link
Contributor

@kowshikRoy kowshikRoy commented Feb 17, 2020

Currently, the implemented code returns null sometimes randomly because of accessing out of bound element. This commit fixes it.

Currently, the implemented code returns null sometimes randomly.
This commit fixes by avoiding out of bound element.
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great find with this old and intermittent bug!

@ezimanyi ezimanyi added the ready to merge Approved and ready for merge label Feb 24, 2020
@mergify mergify bot added the auto merged label Feb 24, 2020
@mergify mergify bot merged commit a543864 into spinnaker:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants