fix(s3): Refactor S3 config to support separate plugin binaries bucket #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
commented
Feb 19, 2020
| @@ -98,6 +98,7 @@ private synchronized void storeCache(String key, byte[] binary) { | |||
| Path binaryPath = CACHE_PATH.resolve(key); | |||
| if (!binaryPath.toFile().exists()) { | |||
| try { | |||
| Files.createDirectories(binaryPath.getParent()); | |||
There was a problem hiding this comment.
Also squeezing in a wee little bug fix if the cache directory doesn't exist. 🙃
|
No code reviews? We have a policy about that, you know... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that we need to support configuring plugin binaries to go to a different bucket. The normal S3 bucket is typically versioned, whereas the plugin binaries bucket should not be. This refactor keeps all existing S3 configuration the same, but adds all new config for the plugin storage.