fix(aws): Fix Create Server Group button #9865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogonthehorizon
approved these changes
Jul 1, 2022
mrampton
approved these changes
Jul 1, 2022
|
@Mergifyio backport release-1.28.x |
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
(cherry picked from commit bd937f9)
✅ Backports have been created
|
link108
added a commit
that referenced
this pull request
Jul 6, 2022
Co-authored-by: Sergio Quintero <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line
defaults: { account?: string; region?: string; subnet?: string; mode?: string } = {}was not creating an empty object whenbuildNewServerGroupCommand()was being called, causingdefaultsto benulland break the whole function.This adds the manual check and sets
defaultsto empty{}if it's null or undefined.