feat(scripts): Add custom auto-external configurer for rollup #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing rollup plugin `rollup-plugin-auto-external` does not handle imports with path in them such as `bootstrap/dist/js/bootstrap`. So creating a simple external configurer that handles such scenarios along with handling scoped packages. This configurer uses the passed in dependencies map and accurately marks npm imports as externals.
vigneshm
force-pushed
the
rollup-externals
branch
from
b50c9f8 to
c0f30c9
Compare
vigneshm
changed the title
|
I'd like to chat about this, mostly so I understand why this is needed |
christopherthielen
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing rollup plugin
rollup-plugin-auto-externaldoes not handle imports with path in them such asbootstrap/dist/js/bootstrap. So creating a simple external configurer that handles such scenarios along with handling scoped packages. This configurer uses the passed in dependencies map and accurately marks npm imports as externals.