Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spel): default new pipelines to spel v4 #7917

Merged
merged 4 commits into from
Feb 19, 2020
Merged

feat(spel): default new pipelines to spel v4 #7917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3004fb
feat(spel): default new pipelines to spel v4
marchello2000 Feb 19, 2020
19e7a9a
Merge branch 'master' into mark/default_to_spelv4
marchello2000 Feb 19, 2020
79f39ad
fixup! feat(spel): default new pipelines to spel v4
marchello2000 Feb 19, 2020
e1541fe
Merge branch 'master' into mark/default_to_spelv4
mergify[bot] Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/scripts/modules/core/src/domain/IPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface IPipeline {
};
type?: string;
updateTs?: number;
spelEvaluator?: string;
}

export interface IPipelineManualStartAlert {
Expand Down
6 changes: 2 additions & 4 deletions app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export class CreatePipelineModal extends React.Component<ICreatePipelineModalPro
application: this.props.application.name,
limitConcurrent: true,
keepWaitingPipelines: false,
spelEvaluator: 'v4',
};
}

Expand Down Expand Up @@ -389,10 +390,7 @@ export class CreatePipelineModal extends React.Component<ICreatePipelineModalPro
</div>
<div className="col-md-7">
<Select
options={[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the linter autofixed this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true. Sometimes new Prettier versions disagree with older ones.

{ label: 'Pipeline', value: false },
{ label: 'Strategy', value: true },
]}
options={[{ label: 'Pipeline', value: false }, { label: 'Strategy', value: true }]}
clearable={false}
value={this.state.command.strategy ? { label: 'Strategy' } : { label: 'Pipeline' }}
onChange={this.handleTypeChange}
Expand Down