feat(core/amazon/titus): do not allow create/clone in managed clusters #7754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
approved these changes
Jan 9, 2020
app/scripts/modules/titus/src/serverGroup/configure/wizard/pages/ServerGroupBasicSettings.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/managed/DeployingIntoManagedClusterWarning.tsx
Show resolved
Hide resolved
app/scripts/modules/core/src/managed/DeployingIntoManagedClusterWarning.tsx
Outdated
Show resolved
Hide resolved
This was referenced Jan 10, 2020
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
spinnaker#7754) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UI, we're doing a pretty good job preventing users from performing actions that will just get stomped. The create/clone server group flow is a little tricky: we want to let them select "Clone" on a managed server group: they might want to use it as a base to create a different (non-managed) cluster. And we can't disable the "Create server group" button.
This PR adds an alert that invalidates the command whenever they have configured the new server group to be in a managed cluster.
When the user clicks the button to pause management, there's that modal-over-a-modal experience, which I don't like, but it's important to really confirm that the user wants to pause management.
(forgive the deprecated region warning also being here, I am having trouble with my sandbox environment so using some other one)
