fix(core/presentation): Fix controlled/uncontrolled warning for numbe…

…r inputs (#7953) this reverts #7881 and fixes it in the `orEmptyString` helper method Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
spinnaker · Feb 25, 2020 · dde0456 · dde0456
1 parent f0d0529
commit dde0456
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/scripts/modules/core/src/presentation/forms/inputs/NumberInput.tsx b/app/scripts/modules/core/src/presentation/forms/inputs/NumberInput.tsx
@@ -26,5 +26,5 @@ export function NumberInput(props: INumberInputProps) {
   useInternalValidator(validation, minMaxValidator);
 
   const className = `NumberInput form-control ${orEmptyString(inputClassName)} ${validationClassName(validation)}`;
-  return <input className={className} type="number" value={value} {...otherProps} />;
+  return <input className={className} type="number" value={orEmptyString(value)} {...otherProps} />;
 }
diff --git a/app/scripts/modules/core/src/presentation/forms/inputs/utils.ts b/app/scripts/modules/core/src/presentation/forms/inputs/utils.ts
@@ -1,11 +1,11 @@
 import classNames from 'classnames';
-import { isString } from 'lodash';
+import { isString, isNil } from 'lodash';
 
 import { noop } from 'core/utils';
 
 import { IFormInputValidation } from './interface';
 
-export const orEmptyString = (val: any) => val || '';
+export const orEmptyString = (val: any) => (isNil(val) ? '' : val);
 
 export const validationClassName = (validation = {} as IFormInputValidation) => {
   return classNames({