Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider/google): Added new disks type for gce in clouddriver #5914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jangjaelee
Copy link

@jangjaelee jangjaelee commented Mar 26, 2023

Added new disks type for gce in clouddriver.
currently, only can be used pd-standard and pd-ssd.

reference link : https://cloud.google.com/compute/docs/disks

Added new disks type for gce in clouddriver.
currently, only can be used pd-standard and pd-ssd.
@jangjaelee
Copy link
Author

Detail in issue link: spinnaker/spinnaker#6814

@JangGyeongSik
Copy link

I agree with the issues above.

It would be nice to add Balanced Diks and Extreme Disks to GCE.

@jasonmcintosh
Copy link
Member

My only question given this is an enum:

@jasonmcintosh
Copy link
Member

https://github.com/search?q=org%3Aspinnaker%20pd-ssd&type=code

FYI quite a few other places look like they'd need to be changed to support this. We can merge this, but more will be required.

@mattgogerly mattgogerly added the ready to merge Approved and ready for a merge label Jul 25, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Jul 25, 2023
@mattgogerly
Copy link
Member

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 17, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/build.yml without workflows permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants