fix(cf): Improved caching agent robustness #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 25, 2020 08:47
Makes for deeper and informative stack traces.
Was happening at startup when both the LoadBalancer and Application caching agents were first ran and shared the same client.
An on-demand cache refresh creates an ON_DEMAND cache entry that never been processed so the `processedCount` was null instead of 0 and the scheduled cache agent wasn't expecting that.
When not found, a serverGroup wouldn't be evicted from the cache upon an on-demand request.
asgard-r
pushed a commit
to armory-io/clouddriver
that referenced
this pull request
Mar 5, 2020
* fix(cf): Skip caching CF apps having frigga incompatible names * fix(cf): Stop swallowing exception causes. Makes for deeper and informative stack traces. * fix(cf): Race condition causing NPE getting token in the HTTP Client. Was happening at startup when both the LoadBalancer and Application caching agents were first ran and shared the same client. * fix(cf): NPE after on-demand cache refresh run An on-demand cache refresh creates an ON_DEMAND cache entry that never been processed so the `processedCount` was null instead of 0 and the scheduled cache agent wasn't expecting that. * fix(cf): Adjusted log verbosity level * fix(cf): Re-enabling cache eviction of a serverGroup on-demand When not found, a serverGroup wouldn't be evicted from the cache upon an on-demand request. * fix(cf): Sensible defaults for cache data retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(cf): Skip caching CF apps having frigga incompatible names
fix(cf): Stop swallowing exception causes.
Makes for deeper and informative stack traces.
fix(cf): Race condition causing NPE getting token in the HTTP Client.
Was happening at startup when both the LoadBalancer and Application caching agents were first ran and shared the same client.
fix(cf): NPE after on-demand cache refresh run
An on-demand cache refresh creates an ON_DEMAND cache entry that never been processed so the
processedCountwas null instead of 0 and the scheduled cache agent wasn't expecting that.fix(cf): Adjusted log verbosity level
fix(cf): Re-enabling cache eviction of a serverGroup on-demand
When not found, a serverGroup wouldn't be evicted from the cache upon an on-demand request.
fix(cf): Sensible defaults for cache data retrieval