Merge cockroachdb#133839

133839: release: update versions should properly handle errors r=jlinder a=rail Previously, the update versions script was wrongly using the `err` variable to set the status of a command execution results. This PR fixes the issue, where a command fails, but the script ignores the error. Epic: none Release note: None Co-authored-by: Rail Aliiev <[email protected]>
spilchen · Oct 30, 2024 · 7433edc · 7433edc
2 parents b451d8f + c97076f
commit 7433edc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/cmd/release/update_versions.go b/pkg/cmd/release/update_versions.go
@@ -282,7 +282,8 @@ func updateVersions(_ *cobra.Command, _ []string) error {
 	var prs []string
 	var workOnRepoErrors []error
 	for _, repo := range reposToWorkOn {
-		repo.workOnRepoError = workOnRepo(repo)
+		err := workOnRepo(repo)
+		repo.workOnRepoError = err
 		if repo.workOnRepoError != nil {
 			err = fmt.Errorf("workOnRepo: error occurred while working on repo %s: %w", repo.name(), err)
 			workOnRepoErrors = append(workOnRepoErrors, err)