Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envoy with federation example #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarcosDY
Copy link
Collaborator

Add envoy + federation example using "ALL" resource

@MarcosDY MarcosDY changed the title Add envoy with federation example [WIP] Add envoy with federation example Sep 13, 2021
@MarcosDY MarcosDY changed the title [WIP] Add envoy with federation example Add envoy with federation example Sep 14, 2021
@SilvaMatteus
Copy link

Hi @MarcosDY ,

Thanks for this example! I was able to run and test it. Everything ok, except for the versions that may be too old.

I have a few comments about it:

  • I guess we could update versions before merging this one.
  • Main readme does not contain link to the example.
  • Maybe it would worth to add some comments about the requests flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants