Force rotation proposal for upstream authority #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosDY
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
MarcosDY
commented
Sep 4, 2023
|
|
||
| // The list of X.509 authorities that are no longer secure to use, | ||
| // and must be rotated. | ||
| repeated X509TaintedKey x509_tainted_keys = 6; |
There was a problem hiding this comment.
It is only required for x509 authorities, but it feels strange to not have the same list for JWT authorities, what do you think?
Signed-off-by: Marcos Yacob <[email protected]>
Signed-off-by: Marcos Yacob <[email protected]>
MarcosDY
force-pushed
the
force-upstream-proposal
branch
from
8acfd9f
to
fbe8cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Upstream authorities, intermediate certificates are not part of bundle, because bundle is the upstream authority CA,
because of that we need to provide a way to propagate the list of tainted keys in case of X.509 authorities, (in JWT it is not required becase our JWT authority is always in datastore)