Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for X509 and JWT specific SVID TTLs #29

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Adds support for X509 and JWT specific SVID TTLs #29

merged 2 commits into from
Sep 21, 2022

Conversation

dennisgove
Copy link
Contributor

This change is in reference to a new SPIRE feature discussed in spiffe/spire#2700

Signed-off-by: Dennis Gove [email protected]

This was referenced Sep 21, 2022
Merged
Closed
@azdagron
Copy link
Member

This looks great @dennisgove. I need to update the CONTRIBUTING docs on this, but can you target this PR against the next branch? We only pull things into main when we are cutting a release.

Also, would you mind documenting the ttl field with a notice of deprecation? something along the lines of, This field is deprecated in favor of the x509_svid_ttl and jwt_svid_ttl fields and will be removed in a future release.

@dennisgove dennisgove changed the base branch from main to next September 21, 2022 20:31
@dennisgove
Adds support for X509 and JWT specific SVID TTLs
212ccb5 
This change is in reference to a new SPIRE feature discussed in spiffe/spire#2700

Signed-off-by: Dennis Gove <[email protected]>
@dennisgove
Copy link
Contributor Author

Thanks @azdagron. I've rebased off next and moved the PR to that branch. Have also added a deprecation notice on the ttl field. I'll add a similar deprecation notice in the spire codebase.

@azdagron
Copy link
Member

Awesome. Looks like make needs to be run again to regen the code after adding that comment.

azdagron
azdagron approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dennisgove !

@azdagron azdagron merged commit 0be45cf into spiffe:next Sep 21, 2022
@dennisgove dennisgove deleted the jwt-ttl-2700 branch October 19, 2022 23:57
guilhermocc pushed a commit to guilhermocc/spire-api-sdk that referenced this pull request Apr 10, 2023
@azdagron
Update CODEOWNERS (spiffe#29)
118dccc 
Updates to reflect current SPIRE CODEOWNERS.

Signed-off-by: Andrew Harding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azdagron azdagron azdagron approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@amartinezfayo amartinezfayo Awaiting requested review from amartinezfayo amartinezfayo is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisgove @azdagron