Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github links #23

Merged
merged 1 commit into from
May 9, 2022
Merged

Update github links #23

merged 1 commit into from
May 9, 2022

Conversation

azdagron
Copy link
Member

@azdagron azdagron commented May 9, 2022

This change updates links to github repositories to incorporate renames
to their default branches.

This change updates links to github repositories to incorporate renames
to their default branches.

Signed-off-by: Andrew Harding <[email protected]>
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@azdagron azdagron merged commit 99a01fa into next May 9, 2022
@azdagron azdagron deleted the update-github-links branch May 9, 2022 15:31
azdagron added a commit to azdagron/spire-api-sdk that referenced this pull request Oct 28, 2022
This change updates links to github repositories to incorporate renames
to their default branches.

Signed-off-by: Andrew Harding <[email protected]>
azdagron added a commit that referenced this pull request Oct 28, 2022
This change updates links to github repositories to incorporate renames
to their default branches.

Signed-off-by: Andrew Harding <[email protected]>
guilhermocc pushed a commit to guilhermocc/spire-api-sdk that referenced this pull request Apr 10, 2023
The `git_dirty` variable was not being set in the Makefile, so the
`git-clean-check` was incorrectly always returning a success exit code.
Set the `git_dirty` variable so that the make target works as expected.

Also set `--no-pager` in the Git commands to better handle environments
where the Git configuration uses the pager for output, which requires
interactive input to close the editor with the Git command output.

Signed-off-by: Ryan Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants