Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac M1 support #22

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add Mac M1 support #22

merged 1 commit into from
Apr 29, 2022

Conversation

faisal-memon
Copy link
Contributor

Signed-off-by: Faisal Memon [email protected]

Adds Mac M1 support to this repo. PR is opened against next branch as that seems to have the latest code. Can switch to main if thats better. The changes in this PR are:

  • Add arm64 target. M1 identifies as arm64 instead of aarch64
  • Use arch2 to identify protoc_url. arch2 will match for M1 and other arm platforms.
  • Update to protoc 3.20.1. Older versions don't support M1.
  • Regenerated *.pb.go files.

Signed-off-by: Faisal Memon <[email protected]>
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, next is the right branch for PRs to target and the branch that SPIRE depends on. We pull officially supported things into main and tag from there as part of releasing.

This looks good. Thanks for this :)

@azdagron azdagron merged commit fe82528 into spiffe:next Apr 29, 2022
@faisal-memon faisal-memon deleted the mac-m1 branch May 2, 2022 17:49
MarcosDY pushed a commit to MarcosDY/spire-api-sdk that referenced this pull request Sep 9, 2022
azdagron pushed a commit that referenced this pull request Sep 9, 2022
Signed-off-by: Faisal Memon <[email protected]>
guilhermocc pushed a commit to guilhermocc/spire-api-sdk that referenced this pull request Apr 10, 2023
df437a2 introduced a change to a `.proto`
file, but didn't include the update to the generated Go code. This PR
was generated by running `make` on `HEAD` of the `main` branch.

Signed-off-by: Ryan Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants