Skip to content

Commit

Permalink
PR changes
Browse files Browse the repository at this point in the history
Signed-off-by: Marcos Yacob <[email protected]>
  • Loading branch information
MarcosDY committed Aug 6, 2024
1 parent 316a3aa commit 796ea0d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 13 deletions.
10 changes: 5 additions & 5 deletions proto/spire/api/server/localauthority/v1/localauthority.proto
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ service LocalAuthority {
// the tainted authority. The result of this action will be observed
// cluster-wide.
// It is important to change active upstream authority before taiting it,
// since taint will force the rotation of any bundle that is using
// since tainting will force the rotation of any bundle that is using
// the old upstream authority.
// It receive the X.509 Subject Key Identifier (or SKID) of an old X.509 authority.
// It receives the X.509 Subject Key Identifier (or SKID) of an old X.509 authority.
//
// If a X.509 upstream authority does not exist or it is active, a FailedPrecondition
// If an X.509 upstream authority does not exist or it is active, a FailedPrecondition
// error will be returned.
rpc TaintX509UpstreamAuthority(TaintX509UpstreamAuthorityRequest) returns (TaintX509UpstreamAuthorityResponse);

Expand All @@ -99,7 +99,8 @@ service LocalAuthority {
// RevokeX509UpstreamAuthority revokes the previously active X.509 upstream authority by
// removing it from the bundle and propagating this update throughout
// the cluster.
// It receive the subject key ID an old X.509 upstream authority.
// It receives the subject key ID of the authority's CA certificate of the
// upstream X.509 authority to revoke.
//
// If a previously active X.509 upstream authority does not exist, a FailedPrecondition
// error will be returned.
Expand Down Expand Up @@ -236,7 +237,6 @@ message RevokeX509AuthorityResponse {
AuthorityState revoked_authority = 1;
}


message AuthorityState {
// The authority ID.
string authority_id = 1;
Expand Down
18 changes: 10 additions & 8 deletions proto/spire/api/server/localauthority/v1/localauthority_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 796ea0d

Please sign in to comment.