Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable race detection when running tests #270

Merged

Conversation

strideynet
Copy link
Contributor

Adds -race to the invocation of go test in the test target of the Makefile. This is generally considered a good practice as it enables catching potential races earlier.

Looks like the test suite runs happily with the race detector enabled 🥳

Whilst this can reduce the speed at which the test suite runs, it doesn't look like this produces a significant change for this test suite on my local machine, especially given the relatively small size of the suite at the moment.

@strideynet strideynet force-pushed the strideynet/enable-race-detection-in-testing branch from e88b77e to 58060de Compare March 6, 2024 16:56
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strideynet !

@azdagron azdagron merged commit 8e0ce79 into spiffe:main Apr 1, 2024
6 checks passed
@strideynet strideynet deleted the strideynet/enable-race-detection-in-testing branch April 2, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants