-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mamba
support
#22
Conversation
959b3ce
to
dc8e8a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job so far! Added more suggestions, this time for rather smaller things
Please rebase after #21 |
132680f
to
e8e485e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, we are almost there, only final touches now. Ping me when you think it's ready to merge.
@spietras ready to merge, thanks for your prompt code reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great job 💯
Thanks for contributing to rules_conda
💚
This implements the ability to use mamba, in accordance with our design discussion.
Design considerations
I commented out the call to
_update_conda
. I found it confusing that we specify the version of conda in the build file, but then ask conda to update itself. This seems to go against the "Bazel way" (if I can call it that) of specifying the exact versions for every input to the build process. Can I remove the_update_conda
function?Testing
I manually tested this by running the test in tests/ with the following modifications:
To elaborate on what these bullet points mean, for the first bullet point I would do the following:
I would repeat this process, manually changing the value of
use_mamba
andclean
for each bullet point. In between each bullet point, I runbazel clean --expunge
. Now I would like to make an automated version of these tests, but the only idea I have for that is to make a bunch of directories under tests/ with their own WORKSPACE and BUILD files and change theuse_mamba
andclean
flags to the matrix of combinations I specified above. Then there would be a test script that goes to each directory and runsbazel test //...
. The problem is that that approach would duplicate a lot of files, just to change two flags. Do you have any better idea for structuring the tests?TODO
Before merging this PR, I would like to: