Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry if RESOURCE_EXHAUSTED or CANCELLED error received #124

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented Jan 20, 2024

Note: I've enabled retry additionally for UNKNOWN error as part of this change:

https://chromium.googlesource.com/external/github.com/grpc/grpc/+/refs/tags/v1.21.4-pre1/doc/statuscodes.md

Unknown error. For example, this error may be returned when a Status value received from another address space belongs to an error space that is not known in this address space. Also errors raised by APIs that do not return enough error information may be converted to this error.

@sgrebnov sgrebnov changed the title Don't retry if RESOURCE_EXHAUSTED and CANCELLED error received Don't retry if RESOURCE_EXHAUSTED or CANCELLED error received Jan 20, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sgrebnov sgrebnov merged commit c57c513 into trunk Jan 22, 2024
6 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/retry-improve branch January 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants