Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spice user agent, update for clippy rules #44

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

peasee
Copy link
Contributor

@peasee peasee commented Sep 18, 2024

🗣 Description

  • Updates all code to address existing clippy pedantic rules
  • Adds get_user_agent to retrieve user agent for a specific system type, including a regex test for checking the contents of the string
  • Updates the test workflow to be more robust
  • Adds x-spice-user-agent header to Flight client

🔨 Related Issues

@peasee peasee added the enhancement New feature or request label Sep 18, 2024
@peasee peasee requested a review from a team September 18, 2024 11:07
@peasee peasee self-assigned this Sep 18, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@peasee peasee marked this pull request as ready for review September 19, 2024 07:52
src/client.rs Outdated Show resolved Hide resolved
@peasee peasee merged commit 9db5f08 into trunk Sep 19, 2024
10 checks passed
@phillipleblanc phillipleblanc deleted the feat/add-spice-user-agent branch September 19, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(rs): Add x-spice-user-agent header to Runtime requests
2 participants