Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add x-spice-user-agent header #25

Merged
merged 4 commits into from
Oct 5, 2024
Merged

feat: Add x-spice-user-agent header #25

merged 4 commits into from
Oct 5, 2024

Conversation

peasee
Copy link
Contributor

@peasee peasee commented Oct 4, 2024 •
edited
Loading

🗣 Description

  • Adds x-spice-user-agent header to HTTP and Flight requests
  • Generates user agent on multiple platforms, tested with a regex

🔨 Related Issues

@peasee peasee self-assigned this Oct 4, 2024
@peasee peasee changed the title feat: Add user agent generation and test feat: Add x-spice-user-agent header Oct 4, 2024
@peasee peasee added the enhancement New feature or request label Oct 4, 2024
@peasee peasee added this to the v0.4.0 milestone Oct 4, 2024
@peasee peasee marked this pull request as ready for review October 4, 2024 05:17
@peasee peasee requested a review from a team October 4, 2024 05:30
@peasee peasee merged commit 5f280cd into trunk Oct 5, 2024
9 checks passed
@peasee peasee deleted the feat/add-x-spice-user-agent-header branch October 5, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekim lukekim lukekim approved these changes

Assignees

@peasee peasee

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

task(java): Add x-spice-user-agent header to Runtime requests
2 participants
@peasee @lukekim