Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spice dataset documentation #734

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

Advayp
Copy link
Collaborator

@Advayp Advayp commented Jan 9, 2025

🗣 Description

  • Explain configure subcommand
  • Add example output for spice dataset configure

🔨 Related Issues

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spiceai-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 1:07am

@Sevenannn
Copy link
Contributor

Thanks for the update! I found there's some issue with the Vercel deployment. Could you please try follow the doc readme and see if the changes can be deployed on local server?

@Advayp
Copy link
Collaborator Author

Advayp commented Jan 11, 2025

Thanks for the update! I found there's some issue with the Vercel deployment. Could you please try follow the doc readme and see if the changes can be deployed on local server?

I'm not sure why the deployment is failing. There was a build issue which I fixed in my latest commit that caused the build_and_publish workflow to run successfully. Is that the error you were referring to?

@Sevenannn
Copy link
Contributor

Yeah that's the error I was referring to that's causing vercel preview comments to fail. I don't have access to vercel and not quite sure on what's going on with vercel deployment failure, will approve your PR and invite someone with access to vercel for a second confirmation. Thanks for contributing!

Sevenannn
Sevenannn previously approved these changes Jan 11, 2025
@Sevenannn Sevenannn requested a review from ewgenius January 11, 2025 16:52
@lukekim
Copy link
Contributor

lukekim commented Jan 13, 2025

@Advayp you need to resolve the conflicts.

Co-authored-by: Jack Eadie <[email protected]>
@Jeadie Jeadie merged commit 1cc0f6e into trunk Jan 14, 2025
3 checks passed
@Jeadie Jeadie deleted the advay/enhance-cli-dataset-docs branch January 14, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance spice dataset documentation
4 participants