Document mysql_user_key parameter
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
digadeesh
reviewed
Jul 8, 2024
Co-authored-by: Aurash Behbahani <[email protected]>
Co-authored-by: Aurash Behbahani <[email protected]>
digadeesh
approved these changes
Jul 8, 2024
ewgenius
reviewed
Jul 8, 2024
| @@ -23,7 +23,8 @@ The MySQL data connector can be configured by providing the following `params`: | |||
| - `mysql_host`: The hostname of the MySQL server. | |||
| - `mysql_tcp_port`: The port of the MySQL server. | |||
| - `mysql_db`: The name of the database to connect to. | |||
| - `mysql_user`: The username to connect with. | |||
| - `mysql_user_key`: The name of the secret key containing the MySQL username. | |||
| - `mysql_user`: The MySQL username. Ignored if `mysql_user_key` is provided. | |||
| - `mysql_pass_key`: The secret key containing the password to connect with. | |||
There was a problem hiding this comment.
Suggested change
| - `mysql_pass_key`: The secret key containing the password to connect with. | |
| - `mysql_pass_key`: The name of the secret key containing the password to connect with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Document
mysql_user_keysecret support🔨 Related Issues
https://github.com/spiceai/spiceai/pull/1886/files