Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Add timeout add file_format to params #244

Merged
merged 4 commits into from
May 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions spiceaidocs/docs/data-connectors/s3.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,14 @@ Example: `name: cool_dataset`

- `endpoint`: The S3 endpoint, or equivalent (e.g. MinIO endpoint), for the S3-compatible storage. E.g. `endpoint: https://my.minio.server`
- `region`: Region of the S3 bucket, if region specific. E.g. `region: us-east-1`
- `timeout`: Timeout for S3 operations. E.g. `timeout: 60s`
sgrebnov marked this conversation as resolved.
Show resolved Hide resolved

## Auth

Not required for public endpoints.

- `key`: The access key (e.g. `AWS_ACCESS_KEY_ID` for AWS)
- `secret`The secret key (e.g. `AWS_SECRET_ACCESS_KEY` for AWS)
- `secret`: The secret key (e.g. `AWS_SECRET_ACCESS_KEY` for AWS)

For endpoints protected by access keys, `key` and `secret` are required and must be passed using a [Secrets Store](/secret-stores) or via `spice s3 login`.
By default S3 connector will look for a secret named `s3` with keys `key` and `secret`.
Expand Down Expand Up @@ -67,7 +68,7 @@ Support for dataset specific authentication is on the roadmap.

secrets:
store: env

# <...>
```

Expand All @@ -88,7 +89,7 @@ Support for dataset specific authentication is on the roadmap.

secrets:
store: kubernetes

# <...>
```

Expand All @@ -111,7 +112,7 @@ Support for dataset specific authentication is on the roadmap.

secrets:
store: keyring

# <...>
```

Expand Down