Add a helper function to prepare the inputs #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
launch_shell_job
function by extracting the input preparation logic into a new helper function,prepare_shell_job_inputs
. The launch_shell_job function now calls this helper function to prepare the inputs before submitting or running the job. This allows others to reuse the input preparation logic elsewhere if needed.Use case:
In
aiida-workgraph
, we use the prepare_for_shell_task function to prepare inputs for theShellJob
task, as in thelaunch_shell_job
. The challenge, however, is that we need to keep theprepare_for_shell_task
function up to date with any changes made tolaunch_shell_job
. By extracting the input logic intoprepare_shell_job_inputs
, we can now directly reuse this function in aiida-workgraph, ensuring consistency.