Some fixes from openSUSE #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some build systems like in OBS, using functions without these headers generate an issue about implicit missing headers
| @@ -1436,7 +1436,7 @@ static int sock_set_blocking ( int sock ) | |||
| } | |||
|
|
|||
|
|
|||
| void sock_close ( int sock ) | |||
| static sock_close ( int sock ); | |||
There was a problem hiding this comment.
what is the point of removal sock_close function body?
|
seems unclear what this request should fix? |
|
I picked it up from Fedora. It fixes a build warning with gcc47+ |
|
Could you provide your OS version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the license GPL-2.0 file and some missing includes