Support SPHINXOPTS #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use an all-caps input variable |
SilverRainZ
requested changes
Oct 12, 2022
action.yml
Outdated
| @@ -30,6 +30,10 @@ inputs: | |||
| description: 'Version of Sphinx' | |||
| required: false | |||
| default: '' | |||
| SPHINXOPTS: | |||
There was a problem hiding this comment.
Please use snake_case for this new input parameter. Besides, I favor sphinx_options instead of sphinx_opt.
We can declare the input parameter in lower case, but use upper case in main.sh, GitHub does this conversion for us.
There was a problem hiding this comment.
OK, I have changed it to sphinx_options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to add support for the
SPHINXOPTS.Closes #14.