Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection for out of date files #9360

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Fix detection for out of date files #9360

merged 5 commits into from
Oct 5, 2022

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Jun 17, 2021

Fix detection when targets are out of date.

Fixes #9359.

@tk0miya
Copy link
Member

tk0miya commented Jun 20, 2021

Thank you for your proposal. It seems some tests are failed. Could you check them please?

@marxin
Copy link
Contributor Author

marxin commented Jun 21, 2021

Well, I am not fully sure why the tests fail. I removed 2x shared_result which fixed some tests.
Apart from that I see:

app = <SphinxTestApp buildername='texinfo'>, status = <_io.StringIO object at 0x7ffff0876a60>, warning = <_io.StringIO object at 0x7ffff0876af0>

    @pytest.mark.sphinx('texinfo', testroot='markup-rubric')
    def test_texinfo_rubric(app, status, warning):
        app.build()
        print(app)
    
>       output = (app.outdir / 'python.texi').read_text()

tests/test_build_texinfo.py:74:

but when I run only a single test, it works fine pytest tests/test_build_texinfo.py. So it's likely about sharing SphinxTestApp among tests? Can you please help me?

@marxin
Copy link
Contributor Author

marxin commented Jun 21, 2021

I've got a tentative patch that works. But as said, I'm not much experienced with Sphinx.

@marxin marxin mentioned this pull request Jun 23, 2021
Closed
@marxin
Copy link
Contributor Author

marxin commented Aug 6, 2021

@tk0miya May I please ping this pull request?

@marxin
Copy link
Contributor Author

marxin commented Nov 22, 2021

May I please ping this pull request?

@tk0miya tk0miya changed the base branch from 4.x to 5.x May 22, 2022 12:58
@marxin marxin force-pushed the fix-outdated-files branch from fae4f9d to ca6605c Compare October 3, 2022 11:35
@marxin marxin force-pushed the fix-outdated-files branch from ca6605c to d3ab80c Compare October 3, 2022 11:41
@marxin
Copy link
Contributor Author

marxin commented Oct 3, 2022

Rebased this pull request. Is it something @AA-Turner can take a look at, please?

AA-Turner
AA-Turner requested changes Oct 5, 2022
View reviewed changes
tests/test_build_latex.py Show resolved Hide resolved
tests/test_build_manpage.py Outdated Show resolved Hide resolved
tests/test_build_texinfo.py Outdated Show resolved Hide resolved
@AA-Turner AA-Turner added this to the 5.3.0 milestone Oct 5, 2022
@marxin marxin requested a review from AA-Turner October 5, 2022 09:44
@AA-Turner
Copy link
Member

Please add a CHANGES entry

A

@marxin
Copy link
Contributor Author

marxin commented Oct 5, 2022

Please add a CHANGES entry

Done.

AA-Turner
AA-Turner reviewed Oct 5, 2022
View reviewed changes
CHANGES Outdated Show resolved Hide resolved
@AA-Turner AA-Turner changed the title Fix detection when targets are out of date. Fix detection for out of date files Oct 5, 2022
@AA-Turner AA-Turner merged commit b1390c4 into sphinx-doc:5.x Oct 5, 2022
@AA-Turner
Copy link
Member

Thanks @marxin!

A

@marxin
Copy link
Contributor Author

marxin commented Oct 5, 2022

I thank you!

@marxin marxin deleted the fix-outdated-files branch October 5, 2022 13:46
marxin added a commit to marxin/sphinx that referenced this pull request Oct 10, 2022
@marxin
Revert "Fix detection for out of date files (sphinx-doc#9360)"
b48fca0 
This reverts commit b1390c4.

The change is reverted because some Builders don't have
a more fine-grained support for outdated docs:
sphinx-doc#10903 (comment)
marxin added a commit to marxin/sphinx that referenced this pull request Oct 10, 2022
@marxin
Revert "Fix detection for out of date files (sphinx-doc#9360)"
33a40bd 
This reverts commit b1390c4.

The change is reverted because some Builders don't have
a more fine-grained support for outdated docs:
sphinx-doc#10903 (comment)

Fixes: sphinx-doc#10903.
AA-Turner pushed a commit that referenced this pull request Oct 13, 2022
@marxin
Revert "Fix detection for out of date files (#9360)" (#10908)
e008e16 
This reverts commit b1390c4.

The change is reverted because some builders don't have
fine-grained support for outdated docs:
#10903 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
builder type:bug
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

Some buildernames does not support caching
3 participants
@marxin @tk0miya @AA-Turner