Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7723: LaTeX: pdflatex crashed when URL contains a single quote #7778

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Fix #7723: LaTeX: pdflatex crashed when URL contains a single quote #7778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ Bugs fixed
* #7646: handle errors on event handlers
* #4187: LaTeX: EN DASH disappears from PDF bookmarks in Japanese documents
* #7701: LaTeX: Anonymous indirect hyperlink target causes duplicated labels
* #7723: LaTeX: pdflatex crashed when URL contains a single quote
* #7756: py domain: The default value for positional only argument is not shown
* C++, fix rendering and xrefs in nested names explicitly starting
in global scope, e.g., ``::A::B``.
Expand Down
3 changes: 2 additions & 1 deletion sphinx/writers/latex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,8 @@ def encode_uri(self, text: str) -> str:
# mainly, %, #, {, } and \ need escaping via a \ escape
# in \href, the tilde is allowed and must be represented literally
return self.encode(text).replace('\\textasciitilde{}', '~').\
replace('\\sphinxhyphen{}', '-')
replace('\\sphinxhyphen{}', '-').\
replace('\\textquotesingle{}', "'")

def visit_Text(self, node: Text) -> None:
text = self.encode(node.astext())
Expand Down