basic theme: Avoid clashes between sidebar and other blocks

[mgeier]

When following a sidebar, these blocks should not be squished next to the sidebar, but they should start after the end of the sidebar in their full width:

• admonitions
• topics
• code blocks
• further sidebars

[mgeier]

I think it might be better to clear only "right" in the case of a sidebar.
Feel free to squash ae9ae3e.

[tk0miya]

Could you paste screenshots for before and after this change?
I can't imagine what is happened now.

[mgeier]

Sure.

.. sidebar:: Sidebar 1

   Text.

.. sidebar:: Sidebar 2

   Text.

.. topic:: Topic

   Text.

Before:

After:

The second one is better, isn't it?

[tk0miya]

LGTM with nits.

[tk0miya]

Thank you for explanation. I've forgotten how sidebars are rendered. +1 for bugfix.

[tk0miya]

Thanks!

[return42]

The second one is better, isn't it?

depends on the use case .. TLDR; its just another broken solution.

Since you will normally not really often have one after the other sidebar I prefer as it was .. Did you ever seen a contents and a sidebar directive on the top of a document .. example .. "second" looks horrible while first is overlapping, which looks much nicer to me.

before #7484

after #7484

[return42]

FWIW: here is my hot-fix (not widely tested):

div.sidebar {
    clear: none;
}

div.admonition, div.topic, pre {
    clear: none;
}

[mgeier]

I'm quite sure that the changes for div.sidebar and for code blocks are good for all themes.
@return42 Would you agree?

I admit that I might have been over-eager in adding div.admonition and div.topic into the mix.
It would probably be better to remove those from the basic theme and add them individually to those themes where it is necessary.

@return42 Would you like to make a PR for this (I think it would be good to use the 3.1.x branch)?

[mgeier]

I'm suggesting to partially revert this PR in #7878.