Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5497: Do not include MathJax.js and jsmath.js unless it is really needed #5536

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Oct 15, 2018

Feature or Bugfix

  • Feature
  • Bugfix

Purpose

@tk0miya tk0miya added this to the 1.8.2 milestone Oct 15, 2018
@tk0miya tk0miya force-pushed the 5497_install_mathjax_only_if_needed branch from 4ee18bf to 410f94f Compare October 16, 2018 16:11
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #5536 into 1.8 will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #5536      +/-   ##
==========================================
- Coverage   82.04%   82.04%   -0.01%     
==========================================
  Files         306      300       -6     
  Lines       40367    40047     -320     
  Branches     6240     6187      -53     
==========================================
- Hits        33121    32858     -263     
+ Misses       5861     5812      -49     
+ Partials     1385     1377       -8
Impacted Files Coverage Δ
tests/test_ext_math.py 84.42% <100%> (+1.09%) ⬆️
sphinx/ext/jsmath.py 89.36% <66.66%> (-1.95%) ⬇️
sphinx/ext/mathjax.py 89.06% <66.66%> (-1.42%) ⬇️
sphinx/domains/math.py 74.41% <77.77%> (+0.39%) ⬆️
sphinx/make_mode.py
sphinx/search/__init__.py
sphinx/quickstart.py
sphinx/errors.py
sphinx/__init__.py
sphinx/apidoc.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2b86c...2e6e940. Read the comment docs.

@tk0miya tk0miya force-pushed the 5497_install_mathjax_only_if_needed branch from 410f94f to 2e6e940 Compare October 16, 2018 16:42
@tk0miya tk0miya merged commit 1af1d8a into sphinx-doc:1.8 Oct 25, 2018
@tk0miya tk0miya deleted the 5497_install_mathjax_only_if_needed branch October 25, 2018 14:03
@mitya57 mitya57 mentioned this pull request Oct 28, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant