Fix #4784: latex_show_urls assigns incorrect footnote numbers #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Apr 10, 2018
| class SubstitutionDefinitionsRemover(SphinxTransform): | ||
| """Remove ``substitution_definition node from doctrees. | ||
|
|
||
| .. note:: In Sphinx-1.7, this transform is only used in LaTeX builder. |
There was a problem hiding this comment.
I added this as local transform for LaTeX builder. But substituion_definition node is not used in all of builders. So I'll move this to normal transform which is invoked in reading phase, in master branch.
tk0miya
force-pushed
the
4784_latex_show_urls_and_substitutions
branch
from
c714600 to
5ef8da5
Compare
Codecov Report
@@ Coverage Diff @@
## 1.7 #4827 +/- ##
==========================================
+ Coverage 81.88% 81.89% +<.01%
==========================================
Files 284 285 +1
Lines 37763 37782 +19
Branches 5875 5876 +1
==========================================
+ Hits 30923 30940 +17
- Misses 5527 5529 +2
Partials 1313 1313
Continue to review full report at Codecov.
|
|
@shimizukawa Thank you for reviewing! |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 14, 2018
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Apr 14, 2018
tk0miya
added a commit
that referenced
this pull request
Apr 21, 2018
…rom_doctree Remove substitution_definition nodes from doctree on reading phase (refs: #4827)
brechtm
added a commit
to brechtm/sphinx
that referenced
this pull request
Sep 8, 2020
SubstitutionDefinitionsRemover is now a SphinxPostTransform, only applied in the Sphinx builder, as was originally the case (see sphinx-doc#4827).
brechtm
added a commit
to brechtm/sphinx
that referenced
this pull request
Sep 8, 2020
SubstitutionDefinitionsRemover is now a SphinxPostTransform, only applied in the Sphinx builder, as was originally the case (see sphinx-doc#4827).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose