fix HTML5 validation check (role attribute of body tag is unnecessary) #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibukawa
force-pushed
the
fix/html5_validation_error
branch
from
ed45a8d to
a34ebb6
Compare
|
Note: HTML5 spec says:
And it is not recommended. |
Blendify
added a commit
to readthedocs/sphinx_rtd_theme
that referenced
this pull request
Jan 15, 2018
Blendify
added a commit
to readthedocs/sphinx_rtd_theme
that referenced
this pull request
Jan 15, 2018
* Do not set the default role for the body tag See https://www.w3.org/TR/html5/sections.html#the-body-element And: sphinx-doc/sphinx#3495 * Remove nav role from nav tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject:
Feature or Bugfix
Purpose
Detail
Relates