-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3351: intersphinx does not refers context #3425
Fix #3351: intersphinx does not refers context #3425
Conversation
A couple random suggestions:
|
0779cae
to
b39b019
Compare
Now I rebased to master HEAD. Unfortunately, I don't have enough time to improve this to all of domains. so I'll do that in future version (@bitprophet Thank you for advice, I've overlooked your comment longer...). @shimizukawa could you review this please? This adds a new interface to Domain class. So it should be reviewed before merging. |
@bitprophet Did you mean like following case?
In this case, intersphinx tries to search both Surely, the next case searches both
|
If that's the case then I misunderstood something, I thought it was only going to search for the fully-qualified |
Ah, sorry. my explanation was wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I haven't seen generated doc, but new API should be described by autodoc, right?
Thank you for reviewing. |
refs: #3351
I added a new interface
Domain.get_full_qualified_name()
to get the full qualified name from the node.It allows to refer a target using context (e.g.
py:module
).get_full_qualified_name()
for other domains => Implement get_full_qualified_name() to C, C++, JavaScript and reST domains #3630get_full_qualified_name()