-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3356 and #3394 latex text layout for Japanese document #3387
Conversation
…se documents - make text width integer multiple of zenkaku width - fix incompatibility of ``geometry`` package with ``jsbook`` LaTeX class (``'manual'`` docclass) - fix issue with shortened text area height in ``'manual'`` docclass
bac00b2
to
9c6a071
Compare
squashed and rebase and now also fixes #3394 issue |
doc/config.rst
Outdated
``'\\usepackage[margin=1in,marginparwidth=0.5in]{geometry}'``. | ||
``'\\usepackage{geometry}'`` (with ``[dvipdfm]`` for Japanese documents) | ||
|
||
and :file:`sphinx.sty` executes a ``\PassOptionsToPackages`` with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here ...Package
the Note: this PR adds the feature of customizability of the document margins. I have also included the width for margin annotations, but perhaps this should be kept undocumented because there is anyhow no reST interface for putting contents in the margins ? |
Sorry for late. LGTM! |
my time was stolen by colleagues ;-) coincidentally I came back seconds after you completed the review, thanks ! I hesitate a slight bit about the |
This commit moves the location of
geometry
package to aftersphinx
package is loaded; it adds new keys for'sphinxsetup'
allowing to easily configure the page margins, by-passing the legacy 1in
for all margins applied by Sphinx. For Japanese documents, the specified
margins are slightly modified in order for text width to be an integer
multiple of the zw dimension unit, and for text height to have an
integer number of baselines. It is always possible to use directly
'geometry'
key tolatex_elements
for complete control, ifdesired.
Subject:
Feature and Bugfix
manual
docclass has a shorter text area #3356This PR will slightly alter page layout, the most important change being that the text height for
manual
docclass gains 2 baselines. (only for Japanese documents...)Purpose
howto
andmanual
docclass are now handled a bit more similarly.geometry
package syntax (the interface for Japanese documents is more restricted as left and right must be equal and top and bottom too.)Relates
manual
docclass has a shorter text area #3356parskip
package should not be loaded from inside sphinx.sty, but made into a template key, whose loading can be cancelled from conf.py, but this is for another occasion.parskip
package does not look really adapted to Japanese typesetting as it introduces vertical shifts of one half baseline. But anyhow Sphinx usesraggedbottom
config. But again, this PR does nothing withparskip
.this PR does also nothing regarding the matter of dvi specials(see Page layout for Japanesemanual
docclass has a shorter text area #3356 (comment)) final version does after all