Separate cases in stringify and restify with greater precision
#12284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
stringify and restify cases more preciselystringify and restify cases more precisely [part 2e]
AA-Turner
force-pushed
the
cleanup/util-2e-typing-refactor
branch
from
2e5ea02 to
866a2e1
Compare
|
@AA-Turner Since you are working on my PR, I'll let you handle whatever changes you want to do (so that we don't have conflicts if I push something else). Feel free to ping me if you have questions! EDIT: It also appears that CPython 3.13 changed the representation somewhere causing an autodoc test to fail (it happened before you merged my PRs). |
AA-Turner
changed the title
stringify and restify cases more precisely [part 2e]stringify and restify with greater precision
|
Heya, my one comment here is; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of the refactorization of those functions where I moved some code around and refactor some inner cases (with details).