-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaTeX: Fix 'multiply-defined references' PDF build warning when one or more reST labels directly precede a py:module
or automodule
directive
#11333
Conversation
d563dc8
to
02cc662
Compare
py:module
or automodule
directive.py:module
or automodule
directive
py:module
or automodule
directivepy:module
or automodule
directive
py:module
or automodule
directivepy:module
or automodule
directive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
The test is very thorough... see my comments about some details.
Thanks for contribution!
b04fe6f
to
d3e64a9
Compare
Oh there is a typo in the CHANGES (preceed instead of precede). Let me fix this before merging |
ah you had not copied pasted the edited PR title then... tsss... |
d3e64a9
to
e2f66ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution.
I will merge soon.
Fix #11093
Discussion
In the future, a different approach could be envisaged, similar to the one taken by the
texinfo
builder. For now, I decided implementing the minimal number of required changes.@jfbu (for the ping)