Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: Fix 'multiply-defined references' PDF build warning when one or more reST labels directly precede a py:module or automodule directive #11333

Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Apr 17, 2023

Fix #11093

Discussion

In the future, a different approach could be envisaged, similar to the one taken by the texinfo builder. For now, I decided implementing the minimal number of required changes.

@jfbu (for the ping)

@picnixz picnixz force-pushed the fix/11093-latex-duplicated-target-labels branch from d563dc8 to 02cc662 Compare April 17, 2023 10:49
@jfbu jfbu changed the title Fix build warnings when one or more reST labels directly preceed an py:module or automodule directive. LaTeX: Fix 'multiply-defined references' PDF build warnings when one or more reST labels directly precede an py:module or automodule directive Apr 17, 2023
@jfbu jfbu changed the title LaTeX: Fix 'multiply-defined references' PDF build warnings when one or more reST labels directly precede an py:module or automodule directive LaTeX: Fix 'multiply-defined references' PDF build warnings when one or more reST labels directly precede a py:module or automodule directive Apr 17, 2023
@jfbu jfbu changed the title LaTeX: Fix 'multiply-defined references' PDF build warnings when one or more reST labels directly precede a py:module or automodule directive LaTeX: Fix 'multiply-defined references' PDF build warning when one or more reST labels directly precede a py:module or automodule directive Apr 17, 2023
Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

The test is very thorough... see my comments about some details.

Thanks for contribution!

CHANGES Outdated Show resolved Hide resolved
tests/test_build_latex.py Outdated Show resolved Hide resolved
tests/test_build_latex.py Outdated Show resolved Hide resolved
tests/test_build_latex.py Outdated Show resolved Hide resolved
@picnixz picnixz force-pushed the fix/11093-latex-duplicated-target-labels branch 2 times, most recently from b04fe6f to d3e64a9 Compare April 18, 2023 08:38
@picnixz
Copy link
Member Author

picnixz commented Apr 18, 2023

Oh there is a typo in the CHANGES (preceed instead of precede). Let me fix this before merging

@jfbu
Copy link
Contributor

jfbu commented Apr 18, 2023

Oh there is a typo in the CHANGES (preceed instead of precede). Let me fix this before merging

ah you had not copied pasted the edited PR title then... tsss...

@picnixz picnixz force-pushed the fix/11093-latex-duplicated-target-labels branch from d3e64a9 to e2f66ce Compare April 18, 2023 10:13
CHANGES Show resolved Hide resolved
Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.

I will merge soon.

@jfbu jfbu merged commit e2f66ce into sphinx-doc:master Apr 18, 2023
@picnixz picnixz deleted the fix/11093-latex-duplicated-target-labels branch April 18, 2023 11:24
@jfbu jfbu added this to the 6.2.0 milestone Apr 18, 2023
@jfbu jfbu added the type:bug label Apr 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants